alt + arrow right doesn't work in chat window

[Christian Heimes <lists@…>]

version: latest svn build from today

bug: While alt + arrow left switches to the tab on the left in the chat window alt + arrow right doesn't do anything.

additional feature request: While you on it could you please chance the behavior a bit? Personally I find it quite useful when I could change the focus on the tabs circular. For example "alt + arrow left" in a tab that is on the left end of the chat window should jump to the right end. Also it would enhance the usability of the qt/kde interface if a user could chose a tab like in firefox by pressing alt + 1 for the first tab to alt + 9. It's easier than to remember a "alt + char" key combo that is going to change after a restart of licq or even after a chat tab is closed and opened later.

Christian

[erijo]

I just experienced this bug. The bug is in CETabBar::setPreviousTab/setNextTab. currentTab() does not return the index of the current tab, but some kind of id.

I haven't tried it, but the following should work for setPreviousTab:

if (currentTab() == -1)
  return; // No current tab

int tab = indexOf(currentTab()) - 1;
if (tab < 0)
  tab = count() - 1;

setCurrentTab(tabAt(tab));

[erijo]

btw, this should be fixed before 1.3.4.

[erijo]

Replying to Christian Heimes <lists@cheimes.de>:

While you on it could you please chance the behavior a bit? Personally I find it quite useful when I could change the focus on the tabs circular. For example "alt + arrow left" in a tab that is on the left end of the chat window should jump to the right end.

This is already implemented.

Also it would enhance the usability of the qt/kde interface if a user could chose a tab like in firefox by pressing alt + 1 for the first tab to alt + 9. It's easier than to remember a "alt + char" key combo that is going to change after a restart of licq or even after a chat tab is closed and opened later.

I moved this to #1367.

[JG^]

i reported the same problem on IRC in may, but noone answered so i just lived with it :)

my guess that time was that this bug had been introduced by the mouse wheel tab switching patch, because i had an svn version from early april, upgraded to a version where the the mouse wheel patch had been applied and it didn't work anymore.

applied to latest and tested a bit and problem still persists although sometimes difficult to reproduce. but here is a path that should always work (or rather not *g*):

* close all tabs * open one tab * and a second one * open an unread message from another user as the third tab - read msg and close the tab again (i hit ctrl-c). * open a third tab again with another user. hit ctrl-left -- and ctrl-right doesn't work anymore.

JG

[emostar]

Fixed in [4584].

[Rolex]

spam

[anonymous]

Milestone 1.3.4 deleted