Smiley *JOKINGLY* does not work

Hm, this works for me, using Mirabilis 5 emoticon set. Can you elaborate more?

Hi!

Sorry, but i had no time before today. I testet it - between licq-clients it works. But when my partner has Windows-ICQ 5.1 and he sends me the *JOKINGLY*-Smiley, i just receive an empty message. I testet it with a lot of ICQ 5.1-clients - alsways the same - an empty message.

When I send him the Smiley, he receives it...

I could not test it with ICQ 5.0, MIRANDA or something like that.

Max

I will try more test this evening - maybe more smileys don't work, we will see.

Could you try attachment:ticket:1445:licq-1445-no-rtf.patch and see if it solves your problem?

OK, I will try your patch on sunday or monday, because I am not available till then. But I now testet all ICQ 5.1-smileys: three smileys have bugs:

First one:

:-[

You can see a picture of it here: == http://helios.wh2.tu-dresden.de/~max/Smiley1.jpg ==

just comes :- from Windows-clients and so no smiley is generated. When the Windows-ICQ-User sends me the string directly and does not use the smiley-collection to send me the smiley it works. But when he does it by this collection it just comes :- What do I mean with smiley-collection?: You have two ways to generate a smiley - just type in the string which is made to the smiley after pressing "send" or you choose one out of a collection if you do not know what the string is... I hope you know hat I mean. Between Windows-clients it works - does not matter if you use the smiley-collection or you type in the string. But from Windows-ICQ to licq it just works by typing the string. Test it yourself with Windows-ICQ. In licq, when you use the smiley-collection, the clicked smiley is directly made to a string in the message-put-in-field. If you send the message it is made to the smiley again. In Windows, if you use the smiley-collection, you can see the clicked smiley directly as a smiley in your message-put-in-field. Maybe there ist the problem - otherwise it would not work if you put in the string directly in the Windows-ICQ-message-put-in-field too.

Second one:

You know... *JOKINGLY*

Third one:

This smiley ist totally missed in licq Mirabelis 5. It ist this one:

http://helios.wh2.tu-dresden.de/~max/Smiley2.jpg

I also receive an empty message when this smiley is send to me by Windows-ICQ. And this smiley even is not integrated in the smiley-collection in licq.

ICQ 5.1 puts smileys in part of the RTF message, but uses a syntax like:

<##icqimage0015>

The smiley should be updated to include this string as one of the ways to display the display. We may have to check about allowing the < and > signs in the display, they are considered HTML, but should not be rendered as so.

Fixed in r4789.

OK, and what is with this one?

:-[

You can see a picture of it here: == http://helios.wh2.tu-dresden.de/~max/Smiley1.jpg ==

Is it also working now?

Hey, when I try to build a debian-package with the new rtf.cc in source, it gives me mistakes like that:

rtf.cc:5005: error: expected unqualified-id before '<' token rtf.cc:5005: error: expected constructor, destructor, or type conversion before '<' token

This mistake comes with many lines (not only 5005 like here)?

What to do?

And: Ist the Smiley *STOP* than also in Mirabelis-5-Emoticons-Set (as a picture) or does only the string work than?

Replying to max:

Hey, when I try to build a debian-package with the new rtf.cc in source, it gives me mistakes like that: rtf.cc:5005: error: expected unqualified-id before '<' token rtf.cc:5005: error: expected constructor, destructor, or type conversion before '<' token

What is your gcc version?

And: Ist the Smiley *STOP* than also in Mirabelis-5-Emoticons-Set (as a picture) or does only the string work than?

With SVN, both work. Until then only the string for STOP and JOKINGLY worked.

Hi,

I got latest version 4.1.

On a side note, there aren't even 5005 lines. How many lines are ni the rtf.cc file that you have?

Hi!

I downloaded rtf.cc from here:

http://trac.licq.org/browser/trunk/licq/src/rtf.cc?rev=4789

And then:

max@ace2:~$ wc -l rtf.cc 5083 rtf.cc

I guess you saved the file as html then. You need the source file. Update your SVN or download this:

http://trac.licq.org/browser/trunk/licq/src/rtf.cc?rev=4789&format=raw

$ wc -l rtf.cc
    2463 rtf.cc

Ok, it was my mistake. Now, Smileys *JOKINGLY* and :-[ work now, but *STOP* just comes as string - but if I understood correctly, this is normal and will be working with next version.

Thank you for fixing this!

By whe way - I got MSN-Connection problem like here http://www.mail-archive.com/licq-dev@googlegroups.com/msg00241.html

Do YOU know what to do? Maybe you have to open a new ticket...

Replying to max:

Ok, it was my mistake. Now, Smileys *JOKINGLY* and :-[ work now, but *STOP* just comes as string - but if I understood correctly, this is normal and will be working with next version.

It may not be a part of the icon set you are using. I know it is in Mirabilis5.1. It may not be in any other icon sets.

By whe way - I got MSN-Connection problem like here http://www.mail-archive.com/licq-dev@googlegroups.com/msg00241.html Do YOU know what to do? Maybe you have to open a new ticket...

If there isn't a ticket for it already, I will. Not sure why it happens, but it does go away the second time. If you want to discuss it more, please find the ticket or open a new ticket and discuss it there.

Replying to emostar:

Replying to max:

Ok, it was my mistake. Now, Smileys *JOKINGLY* and :-[ work now, but *STOP* just comes as string - but if I understood correctly, this is normal and will be working with next version.

It may not be a part of the icon set you are using. I know it is in Mirabilis5.1. It may not be in any other icon sets.

And it won't be in Mirabilis5 in newer licq-Versions like 1.3.5? Iam asking me why not, becuase this ist the only one missing in comparison with Windows-ICQ-5.0-Smileys.

By whe way - I got MSN-Connection problem like here http://www.mail-archive.com/licq-dev@googlegroups.com/msg00241.html Do YOU know what to do? Maybe you have to open a new ticket...

If there isn't a ticket for it already, I will. Not sure why it happens, but it does go away the second time. If you want to discuss it more, please find the ticket or open a new ticket and discuss it there.

Ok, I will try my best.