Ticket #456 (assigned defect: None)

Opened 5 years ago

Last modified 39 years ago

licq abuses internal curses structures

Reported by: thomasklausner Owned by: emostar
Priority: normal Milestone:
Component: build Version: 1.2.*
Keywords: Cc:

Description

licq abuses internal curses structures instead of using the API. Besides being bad programming practice, this makes it fail to build with NetBSD's native curses.

The attached patch (against 1.2.6) works fine with ncurses-5.3 and NetBSD's curses. Please commit.

Change History

Changed 5 years ago by emostar

Logged In: YES user_id=21415

This makes it work with NetBSD but breaks compatibility on other platforms. The "hack" was put in there for a reason, and it is because there are problems with wattr_set/get on some platforms. I would be willing to include your patch if you can tell me what preprocessor definition I can use to detect if it is being compiled on NetBSD.

Changed 5 years ago by nobody

Logged In: NO

I find your reply slightly strange: If "there are problems with wattr_set/get on some platforms" then why don't you add #ifdef'ed workarounds for those instead?

Which platforms are these?

You can check for NetBSD by using #ifdef NetBSD, but I really recommend you do it the other way round, since, as I said, the patch works with either of ncurses-5.3 and NetBSD's curses perfectly.

Changed 5 years ago by emostar

Logged In: YES user_id=21415

Well, NetBSD is the only platform that I know it is working with. I'll have to look at ncurses to see if it has been fixed for all platforms or what.

Note: See TracTickets for help on using tickets.