Ticket #630 (closed defect: fixed)

Opened 4 years ago

Last modified 12 months ago

DESTDIR installation misbehaving

Reported by: petere78 Owned by: erijo
Priority: low Milestone: 1.3.4
Component: build Version:
Keywords: Cc:

Description (last modified by erijo) (diff)

The "fake root" installation using DESTDIR (for package building) is misbehaving. Here's the problem: plugins/qt-gui/po/Makefile.am sets localedir = $(DESTDIR)$(prefix)/share/licq/qt-gui/locale Later the install-local-data target does $(mkinstalldirs) $(localedir) Automake helpfully thinks that you forgot to put in DESTDIR here and converts this to the following in Makefile.in: $(mkinstalldirs) $(DESTDIR)$(localedir) So DESTDIR is applied twice, which has a pretty stupid effect when building a Debian package at least. I suggest the attached patch. It creates minimally more typing, but contrary to the current code, it works. :)

Change History

Changed 2 years ago by erijo

  • owner changed from dreamforce2 to erijo
  • status changed from assigned to new

Changed 2 years ago by erijo

  • status changed from new to assigned

Changed 2 years ago by erijo

  • description modified (diff)
  • milestone set to 1.3.4

Changed 2 years ago by erijo

  • status changed from assigned to closed
  • resolution changed from None to fixed

Fixed in [4455].

Changed 12 months ago by anonymous

  • milestone 1.3.4 deleted

Milestone 1.3.4 deleted

Changed 12 months ago by erijo

  • milestone set to 1.3.4
Note: See TracTickets for help on using tickets.