Ticket #641 (closed defect: fixed)

Opened 4 years ago

Last modified 11 months ago

"cancel" that becomes "close"

Reported by: zloba_org Owned by: dreamforce2
Priority: normal Milestone: 1.3.4
Component: qt-gui Version:
Keywords: Cc:

Description (last modified by erijo) (diff)

in the chat window, when i hit "Send" and it's in the process of sending the message, "Send" becomes disabled, and "Close" becomes "Cancel". IMHO this is a rather bad idea - here's a scenario (it actually happened once or twice), and i keep expecting it to happen again.

[ What is the point of this transformation anyway? A radical change in function that occurs asynchronously = bad idea ]

I am sending the first message to a user with a slow connection, high latency. I hit send ("Send through server" is Off) - it starts sending it. Then, i start thinking they're behind firewall, and try to cancel it, enable "Send through server" and "Send" again.

However, just as i hit "Cancel", the message does come through, the button becomes "Close" again, and the window gets closed. ARGH!

I would suggest either:

- let "Send" become "Cancel". If the message suddenly comes through, the field will be cleared so nothing bad will happen.

- make a separate "Cancel" button. If the message comes through, it will become disabled, and in any case won't do nothing unexpected. I'd prefer this one.

+ In any case, i'd disable input field while sending (and every other button as well), so that the user cancels explicitly before doing anything else, lest any text becomes lost, or any other surprises happen.

Change History

Changed 4 years ago by dreamforce2

Logged In: YES user_id=527951

Thanks for your report, i'll have a look at it. Thomas

Changed 3 years ago by zloba_org

Logged In: YES user_id=1158242

had this sitting in my build directory for a year

Changed 3 years ago by zloba_org

Logged In: YES user_id=1158242

i was referring to the attached patch - licq.patch.close

Changed 2 years ago by erijo

  • status changed from assigned to closed
  • resolution changed from None to fixed

Fixed in [4452].

Changed 2 years ago by erijo

  • description modified (diff)
  • milestone set to 1.3.4

Changed 2 years ago by zloba

wonderful, thanks! (tried in 1.3.4RC1 - looks good)

Changed 11 months ago by anonymous

  • milestone 1.3.4 deleted

Milestone 1.3.4 deleted

Changed 11 months ago by erijo

  • milestone set to 1.3.4
Note: See TracTickets for help on using tickets.