Ticket #646 (closed defect: fixed)

Opened 4 years ago

Last modified 11 months ago

emoticon support needs improvement

Reported by: petere78 Owned by: erijo
Priority: normal Milestone: 1.3.4
Component: message Version: 1.3.0
Keywords: Cc:

Description (last modified by erijo) (diff)

A Debian user reported the following: Emoticons should only be substituted when they are at the end of a word (i.e., a space, comma, !, period, newline, or EOF follows). Otherwise some strange things happen when you send messages which contain unconventional text.

When copying from a licq window, the underlying text should be copied, not skipped just because licq interprets it as an emoticon. (Especially in chat history)

Regarding copying behavior, in URL links which are recognized and underlined by licq, it is inappropriate to perform emoticon substitution, because then the user cannot copy and paste the URL into the browser.

Attachments

copy-emoticons-as-text.patch (4.6 kB) - added by erijo 2 years ago.
Patch for the second part.

Change History

Changed 4 years ago by wwp

Logged In: YES user_id=329414

If I'm not wrong, Gaim and MSN do the same as Licq. So it happens many times that text containing ":" is replaced w/ a graphical emoticon..

My 2 cts.

Changed 4 years ago by petere78

Logged In: YES user_id=178336

Gentoo has developed a patch with the apparent intention to allow users to turn off emoticons. Maybe this could be integrated. http://www.gentoo.org/cgi-bin/viewcvs.cgi/net-im/licq/files/1.3.0-no_stupid_koloboks.patch?hideattic=1

Changed 4 years ago by emostar

Logged In: YES user_id=21415

petere78:

That patch doesn't add any new behaviour to Licq. The same thing can be done by setting the emoticons to "None" in the Skin Browser (Main Menu->Skin Browser). If it's set to "None", there will be no automatic replacement.

Changed 4 years ago by denisq

Logged In: YES user_id=773803

yes, i agree to him! IMHO you should rewrite a bit the emoticon support because once i wanted to add some, i did not understand how the config worked! it's a simple list of text-smilies.... why don't you do it like Gaim, there is an entry for each file and it's apropriate text-symbol! that much more logical and easier to use! (i wanted to add the original icq 4 emoticons because none of the licq ones are really nice and expressive!)

Changed 2 years ago by erijo

  • description modified (diff)

Changed 2 years ago by erijo

  • owner changed from dreamforce2 to erijo
  • status changed from assigned to new
  • description modified (diff)

Changed 2 years ago by erijo

  • status changed from new to assigned

Changed 2 years ago by erijo

Patch for the second part.

Changed 2 years ago by erijo

  • status changed from assigned to closed
  • resolution changed from None to fixed

As of r4550, all issues in this ticket have been fixed.

Changed 2 years ago by erijo

  • milestone set to 1.3.4

Forgot to set the milestone.

Changed 11 months ago by anonymous

  • milestone 1.3.4 deleted

Milestone 1.3.4 deleted

Changed 11 months ago by erijo

  • milestone set to 1.3.4
Note: See TracTickets for help on using tickets.